Tune up webpacker

paranoicsan · paranoicsan · commit 61f7ae2f1ac4 · 2020-06-10T16:12:51.000+02:00
Introduce new `lcms_engine_javascript_pack_tag` method to be used to include(and compile) lcms-engine based packs. This is a solution to be able to isolate project specific packs and packs created inside the gem. As an alternative we could use the solution provided here - rails/webpacker#348 (comment) This looks more reliable to me.
diff --git a/app/helpers/lcms/engine/application_helper.rb b/app/helpers/lcms/engine/application_helper.rb
@@ -8,8 +8,12 @@ module ApplicationHelper
       include ViewHelper
       include ::Webpacker::Helper
 
-      def current_webpacker_instance
-        Lcms::Engine.webpacker
+      # Use this to include lcms-engine based packs
+      def lcms_engine_javascript_pack_tag(*names, **options)
+        entries = names
+                    .map { |name| Lcms::Engine.webpacker.manifest.lookup!(name, type: :javascript) }
+                    .flatten
+        javascript_include_tag(*entries, **options)
       end
     end
   end
diff --git a/app/views/layouts/lcms/engine/admin.html.erb b/app/views/layouts/lcms/engine/admin.html.erb
@@ -13,7 +13,7 @@
     <%= csrf_meta_tags %>
     <%# NOTE: JS served via Assets pipeline should be added first %>
     <%= javascript_include_tag 'lcms/engine/admin/application', 'data-turbolinks-track' => 'reload' %>
-    <%= javascript_pack_tag 'admin' %>
+    <%= lcms_engine_javascript_pack_tag 'admin' %>
   </head>
   <body>
     <%= render partial: 'lcms/engine/shared/unsupported' %>
