Fetch to Add, Delete, and Update #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmckeon
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
I know it's just a code along, but I'd still like to see the code be "production ready" when you submit it. This time I won't, but going forward, I'm going to make you go back and cleanup your syntax. I really need you to start paying more attention to it. Otherwise, the concepts are there and you're going great, so keep that up!
There was a problem hiding this comment.
Be mindful of committing changes like this.
| function Item({ item }) { | ||
| function Item({ item, onUpdateItem, onDeleteItem }) { | ||
| function handleAddToCartClick() { | ||
| // add fetch request |
There was a problem hiding this comment.
Suggested change
| // add fetch request |
Comment on lines
+17
to
+20
| } | ||
|
|
||
|
|
||
| function handleDeleteClick() { |
There was a problem hiding this comment.
Suggested change
| } | |
| function handleDeleteClick() { | |
| } | |
| function handleDeleteClick() { |
| return ( | ||
| <li className={item.isInCart ? "in-cart" : ""}> | ||
| <span>{item.name}</span> | ||
| <span className="category">{item.category}</span> | ||
| <button className={item.isInCart ? "remove" : "add"}> | ||
| <button onClick={handleAddToCartClick}className={item.isInCart ? "remove" : "add"}> |
There was a problem hiding this comment.
Suggested change
| <button onClick={handleAddToCartClick}className={item.isInCart ? "remove" : "add"}> | |
| <button onClick={handleAddToCartClick} className={item.isInCart ? "remove" : "add"}> |
| {item.isInCart ? "Remove From" : "Add to"} Cart | ||
| </button> | ||
| <button className="remove">Delete</button> | ||
| <button onClick={handleDeleteClick}className="remove">Delete</button> |
There was a problem hiding this comment.
Suggested change
| <button onClick={handleDeleteClick}className="remove">Delete</button> | |
| <button onClick={handleDeleteClick} className="remove">Delete</button> |
Comment on lines
+3
to
+9
| function ItemForm({ onAddItem }) { | ||
| const [name, setName] = useState(""); | ||
| const [category, setCategory] = useState("Produce"); | ||
|
|
||
|
|
||
|
|
||
| function handleSubmit(e) { |
There was a problem hiding this comment.
Suggested change
| function ItemForm({ onAddItem }) { | |
| const [name, setName] = useState(""); | |
| const [category, setCategory] = useState("Produce"); | |
| function handleSubmit(e) { | |
| function ItemForm({ onAddItem }) { | |
| const [name, setName] = useState(""); | |
| const [category, setCategory] = useState("Produce"); | |
| function handleSubmit(e) { |
Comment on lines
+9
to
+25
| function handleSubmit(e) { | ||
| e.preventDefault(); | ||
| const itemData = { | ||
| name: name, | ||
| category: category, | ||
| isInCart: false, | ||
| }; | ||
| fetch("http://localhost:4000/items", { | ||
| method: "POST", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, | ||
| body: JSON.stringify(itemData), | ||
| }) | ||
| .then((r) => r.json()) | ||
| .then((newItem) => onAddItem(newItem)); | ||
| } |
There was a problem hiding this comment.
This whole function needs to be indented.
Comment on lines
+55
to
59
| <Item key={item.id} item={item} | ||
| onUpdateItem={handleUpdateItem} | ||
| onDeleteItem={handleDeleteItem}/> | ||
|
|
||
| ))} |
There was a problem hiding this comment.
Suggested change
| <Item key={item.id} item={item} | |
| onUpdateItem={handleUpdateItem} | |
| onDeleteItem={handleDeleteItem}/> | |
| ))} | |
| <Item key={item.id} item={item} | |
| onUpdateItem={handleUpdateItem} | |
| onDeleteItem={handleDeleteItem}/> | |
| ))} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used fetch requests and state to add, delete, and update things on both the database and the DOM.