Commit 805b789
builtin/rebase: release git_format_patch_opt too
options.git_format_patch_opt can be populated during cmd_rebase's setup,
and will therefore leak on return. Although we could just UNLEAK all of
options, we choose to strbuf_release() the individual member, which matches
the existing pattern (where we're freeing invidual members of options).
Leak found when running t0021:
Direct leak of 24 byte(s) in 1 object(s) allocated from:
#0 0x49ab79 in realloc ../projects/compiler-rt/lib/asan/asan_malloc_linux.cpp:164:3
microsoft#1 0x9ac296 in xrealloc wrapper.c:126:8
microsoft#2 0x93b13d in strbuf_grow strbuf.c:98:2
microsoft#3 0x93bd3a in strbuf_add strbuf.c:295:2
microsoft#4 0x60ae92 in strbuf_addstr strbuf.h:304:2
microsoft#5 0x605f17 in cmd_rebase builtin/rebase.c:1759:3
microsoft#6 0x4cd91d in run_builtin git.c:467:11
microsoft#7 0x4cb5f3 in handle_builtin git.c:719:3
microsoft#8 0x4ccf47 in run_argv git.c:808:4
microsoft#9 0x4caf49 in cmd_main git.c:939:19
microsoft#10 0x69dbfe in main common-main.c:52:11
microsoft#11 0x7f66dae91349 in __libc_start_main (/lib64/libc.so.6+0x24349)
SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s).
Signed-off-by: Andrzej Hunt <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>1 parent a317a55 commit 805b789
1 file changed
+1
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2119 | 2119 | | |
2120 | 2120 | | |
2121 | 2121 | | |
| 2122 | + | |
2122 | 2123 | | |
2123 | 2124 | | |
2124 | 2125 | | |
0 commit comments