Skip to content

Parse tuples in the expression #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 18, 2022
Merged

Parse tuples in the expression #980

merged 8 commits into from
Aug 18, 2022

Conversation

Thirumalai-Shaktivel
Copy link
Collaborator

@Thirumalai-Shaktivel Thirumalai-Shaktivel commented Aug 16, 2022 •
edited
Loading

Closes: #719

@Thirumalai-Shaktivel Thirumalai-Shaktivel added the Parser Issues or improvements related to parser label Aug 16, 2022
@Thirumalai-Shaktivel
Copy link
Collaborator Author

This PR is ready!

@Thirumalai-Shaktivel Thirumalai-Shaktivel force-pushed the tuple branch 3 times, most recently from be868ba to a73c84e Compare August 17, 2022 12:43
certik
certik reviewed Aug 17, 2022
View reviewed changes
certik
certik approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me.

@Thirumalai-Shaktivel
Copy link
Collaborator Author

Thanks for the review!

@Thirumalai-Shaktivel Thirumalai-Shaktivel merged commit 74ad773 into lcompilers:main Aug 18, 2022
@Thirumalai-Shaktivel Thirumalai-Shaktivel deleted the tuple branch August 18, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
Parser Issues or improvements related to parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Parser] Tuples are not parsed by the new parser
2 participants
@Thirumalai-Shaktivel @certik