Skip to content

This shows how to parse a tuple #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 29, 2022
Merged

This shows how to parse a tuple #834

merged 8 commits into from
Jul 29, 2022

Conversation

certik
Copy link
Contributor

@certik certik commented Jul 28, 2022

Related: #719
Closes: #507, #620

@Thirumalai-Shaktivel Thirumalai-Shaktivel added the Parser Issues or improvements related to parser label Jul 28, 2022
@Thirumalai-Shaktivel
Copy link
Collaborator

Thank you @certik, the changes is this PR was really helpful. It solved most of the tuple issues that I noticed in the Numpy repo.

@Thirumalai-Shaktivel
Copy link
Collaborator

This PR will be ready, once we parse the With_statement, which I will do it tomorrow.

@Thirumalai-Shaktivel
Copy link
Collaborator

This PR is ready to go in!

@Thirumalai-Shaktivel Thirumalai-Shaktivel marked this pull request as ready for review July 29, 2022 03:29
Copy link
Contributor Author

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@certik certik merged commit 39e99fd into lcompilers:main Jul 29, 2022
@certik certik deleted the parse_tuple branch July 29, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Parser Issues or improvements related to parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New] Parse Tuple in the Expression
2 participants