Skip to content

[Parser] Fix issues with comment and indentation #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2022
Merged

[Parser] Fix issues with comment and indentation #619

merged 6 commits into from
Jun 17, 2022

Conversation

akshanshbhatt
Copy link
Collaborator

@akshanshbhatt akshanshbhatt commented Jun 16, 2022 •
edited
Loading

Closes #509
Closes #612
Closes #617

Thirumalai-Shaktivel
Thirumalai-Shaktivel approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for this PR.

@Thirumalai-Shaktivel Thirumalai-Shaktivel merged commit 9e3d33c into lcompilers:main Jun 17, 2022
@Thirumalai-Shaktivel Thirumalai-Shaktivel added the Parser Issues or improvements related to parser label Jun 17, 2022
@Thirumalai-Shaktivel
Copy link
Collaborator

Thirumalai-Shaktivel commented Jun 17, 2022 •
edited
Loading

I tested locally, it resolves all the issues related to the comments as far as I know. I tested integration_tests, tests and lpython_builtin: everything passes except #508 and #620

@certik
Copy link
Contributor

certik commented Jun 18, 2022

Great job @akshanshbhatt ! Thanks @Thirumalai-Shaktivel for testing and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@Thirumalai-Shaktivel Thirumalai-Shaktivel Thirumalai-Shaktivel approved these changes

Assignees
No one assigned
Labels
Parser Issues or improvements related to parser
Projects
None yet
Milestone
No milestone
3 participants
@akshanshbhatt @Thirumalai-Shaktivel @certik