Skip to content

Implement cpython support in test_c_interop_03 #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2022
Merged

Implement cpython support in test_c_interop_03 #603

merged 2 commits into from
Jun 14, 2022

Conversation

certik
Copy link
Contributor

@certik certik commented Jun 14, 2022

No description provided.

@certik
Copy link
Contributor Author

certik commented Jun 14, 2022

The test passes, but the expression pointer(xi32, i32) returns a pointer to a copy of the integer xi32, as Python passes a new copy of the integer (as value), so this approach does not allow us to take a pointer to it. I think it's probably fine, we just can't use it for return values. For NumPy arrays arguments it will return a pointer to the actual data.

@certik certik mentioned this pull request Jun 14, 2022
Closed
11 tasks
@certik certik enabled auto-merge June 14, 2022 13:27
@certik
Copy link
Contributor Author

certik commented Jun 14, 2022

This gets it done, in a "prototype" mode. As we get more experience actually using this, we'll "harden" it.

@certik certik merged commit 8745d6d into lcompilers:main Jun 14, 2022
@certik certik deleted the cp2 branch June 14, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@certik