Skip to content

Add dist() function in math.py #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

Aasthaengg
Copy link
Contributor

This PR consists of fsum() prod() and dist() functionality for math module.

These functions are passing the integration test with PYTHONPATH=src/runtime/ltypes python integration_tests/test_math.py but failing with ./src/bin/lpython src/runtime/math.py -o output && ./output as pointed in #455.

@certik
Copy link
Contributor

certik commented May 8, 2022

Thanks!

@Smit-create Smit-create self-assigned this Nov 9, 2022
@Smit-create Smit-create requested a review from czgdp1807 November 9, 2022 12:43
@Smit-create Smit-create removed their assignment Nov 9, 2022
@Smit-create Smit-create added the ready for review PRs that are ready for review label Nov 9, 2022
@Smit-create Smit-create marked this pull request as ready for review November 9, 2022 12:43
@Smit-create Smit-create changed the title fsum(), prod() and dist() functions in math.py with list arguments Add dist() function in math.py Nov 9, 2022
@Smit-create
Copy link
Collaborator

@czgdp1807 This is ready to go in.

Smit-create and others added 2 commits November 27, 2022 01:30
Co-Authored-By: Aastha Singh <[email protected]>
Co-Authored-By: Aastha Singh <[email protected]>
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Smit-create Smit-create merged commit 08b04b0 into lcompilers:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review PRs that are ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants