Refactor the ASR #425
Merged
Refactor the ASR #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namannimmo10
force-pushed
the
refactor_asr4
branch
from
1a1700c to
b3fcec5
Compare
namannimmo10
force-pushed
the
refactor_asr4
branch
from
b3fcec5 to
1d86e00
Compare
namannimmo10
force-pushed
the
refactor_asr4
branch
from
1d86e00 to
e7db6d2
Compare
certik
reviewed
Apr 26, 2022
certik
reviewed
Apr 26, 2022
certik
reviewed
Apr 26, 2022
certik
reviewed
Apr 26, 2022
certik
reviewed
Apr 26, 2022
certik
reviewed
Apr 26, 2022
certik
reviewed
Apr 26, 2022
czgdp1807
reviewed
Apr 27, 2022
namannimmo10
force-pushed
the
refactor_asr4
branch
2 times, most recently
from
3ca87f6 to
a0d2048
Compare
namannimmo10
force-pushed
the
refactor_asr4
branch
from
a0d2048 to
6c36675
Compare
czgdp1807
reviewed
Apr 27, 2022
czgdp1807
reviewed
Apr 27, 2022
czgdp1807
reviewed
Apr 27, 2022
| @@ -35,7 +35,7 @@ struct PythonIntrinsicProcedures { | |||
| {"bool", {m_builtin, &eval_bool}}, | |||
| {"chr", {m_builtin, &eval_chr}}, | |||
| {"ord", {m_builtin, &eval_ord}}, | |||
| {"len", {m_builtin, &eval_len}}, | |||
| // {"len", {m_builtin, &eval_len}}, | |||
There was a problem hiding this comment.
Remove the dead code in a separate PR IMO. It gets confusing otherwise.
czgdp1807
reviewed
Apr 27, 2022
czgdp1807
reviewed
Apr 27, 2022
czgdp1807
reviewed
Apr 27, 2022
namannimmo10
force-pushed
the
refactor_asr4
branch
from
695a97e to
b91b27b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.