Skip to content

Adding str slicing #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2022
Merged

Adding str slicing #423

merged 2 commits into from
May 1, 2022

Conversation

Abdullahjavednesar
Copy link
Collaborator

@Abdullahjavednesar Abdullahjavednesar commented Apr 25, 2022 •
edited
Loading

Fixes #273

@Abdullahjavednesar Abdullahjavednesar mentioned this pull request May 1, 2022
Merged
@Abdullahjavednesar Abdullahjavednesar added the ready for review PRs that are ready for review label May 1, 2022
certik
certik approved these changes May 1, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks for fixing this!

@certik certik merged commit 1081efd into lcompilers:main May 1, 2022
@Abdullahjavednesar Abdullahjavednesar deleted the str_slice branch May 1, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namannimmo10 namannimmo10 namannimmo10 left review comments

@certik certik certik approved these changes

Assignees
No one assigned
Labels
ready for review PRs that are ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix string indexing
3 participants
@Abdullahjavednesar @certik @namannimmo10