Skip to content

Improve the error messages #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2022
Merged

Improve the error messages #418

merged 4 commits into from
Apr 24, 2022

Conversation

namannimmo10
Copy link
Collaborator

No description provided.

@namannimmo10 namannimmo10 marked this pull request as draft April 24, 2022 15:28
@certik
Copy link
Contributor

certik commented Apr 24, 2022 •
edited
Loading

Yes, this is good.

The next step is then to return list[i32] directly from the function if the type is a list. And for arrays we can print i32[n] (or whatever the upper dimension is).

certik
certik approved these changes Apr 24, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thanks!

@namannimmo10 namannimmo10 marked this pull request as ready for review April 24, 2022 18:52
@namannimmo10 namannimmo10 merged commit fff611a into lcompilers:main Apr 24, 2022
@namannimmo10 namannimmo10 deleted the err-msg branch April 24, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namannimmo10 @certik