Skip to content

use nproc to utilise max processing units #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

use nproc to utilise max processing units #381

wants to merge 2 commits into from

Conversation

Aasthaengg
Copy link
Contributor

Using nproc so that there is better compatibility with different build machines and different CPUs

@Smit-create
Copy link
Collaborator

Hi, Thanks for the PR. This seems to be working okay on a Linux machine but does not work on my Mac. Can you please verify?

@Thirumalai-Shaktivel
Copy link
Collaborator

See: #375 (comment)

@Aasthaengg
Copy link
Contributor Author

Aasthaengg commented Apr 15, 2022

@Smit-create and @Thirumalai-Shaktivel, Thanks for pointing it out. I just added an alternate command for Mac users.

@certik
Copy link
Contributor

certik commented Apr 16, 2022

What about Windows?

I would recommend not to complicate this, and just keep things simple. We can reduce to -j8. That way you can increase it if you have more processors.

@Aasthaengg
Copy link
Contributor Author

For windows we can write %NUMBER_OF_PROCESSORS%.
Thank you for the recommendation @certik, sure -j8 sounds good.
I intended to restructure README for multiple operating systems in the same way that build is written.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants