Skip to content

Jupyter Kernel #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2024
Merged

Jupyter Kernel #2764

merged 3 commits into from
Jul 8, 2024

Conversation

Vipul-Cariappa
Copy link
Contributor

@Vipul-Cariappa
Squashed commit of the following:
ef645e5 
commit b1700b2
Author: Vipul Cariappa <[email protected]>
Date:   Mon Jul 8 15:50:28 2024 +0530

    fix

commit 1279555
Author: Vipul Cariappa <[email protected]>
Date:   Mon Jul 8 15:38:58 2024 +0530

    in previous commit I tested by changing compiler to gcc, still fails in macOS

commit 5920f1a
Author: Vipul Cariappa <[email protected]>
Date:   Mon Jul 8 15:28:13 2024 +0530

    .

commit 81918f1
Author: Vipul Cariappa <[email protected]>
Date:   Mon Jul 8 15:19:22 2024 +0530

    .

commit f8ed783
Author: Vipul Cariappa <[email protected]>
Date:   Mon Jul 8 15:12:23 2024 +0530

    .

commit 8f709d1
Author: Vipul Cariappa <[email protected]>
Date:   Mon Jul 8 15:05:16 2024 +0530

    .

commit 69b50d1
Author: Vipul Cariappa <[email protected]>
Date:   Mon Jul 8 15:01:03 2024 +0530

    .

commit 797f644
Author: Vipul Cariappa <[email protected]>
Date:   Mon Jul 8 07:45:37 2024 +0530

    fix .

commit 7e13673
Author: Vipul Cariappa <[email protected]>
Date:   Mon Jul 8 07:37:19 2024 +0530

    fix .

commit e18a15c
Author: Vipul Cariappa <[email protected]>
Date:   Mon Jul 8 07:34:19 2024 +0530

    CI fix

commit de257f5
Merge: 9ec6d6d f414b0f
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 15:03:16 2024 -0600

    Merge branch 'main' into ci_mamba

commit 9ec6d6d
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 14:58:15 2024 -0600

    X

commit e69e069
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 14:44:51 2024 -0600

    Pin zstd, zlib

commit 2ed3ac2
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 14:36:39 2024 -0600

    downgrade

commit c8a80c3
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 12:16:48 2024 -0600

    zstd

commit 1c77ac5
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 12:14:14 2024 -0600

    X

commit ba8a13c
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 12:12:20 2024 -0600

    Fix nlohmann_json

commit 81beb7c
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 12:10:20 2024 -0600

    Pin packages

commit e4fa09a
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 11:58:09 2024 -0600

    List

commit ae16656
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 11:54:47 2024 -0600

    Do not upgrade installed packages

commit e73253e
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 11:50:47 2024 -0600

    Pin the packages

commit d1dc5f0
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 11:47:13 2024 -0600

    Use latest version

commit 0c3b95b
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 11:39:46 2024 -0600

    Fix Windows test

commit 34613d7
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 11:24:17 2024 -0600

    Use xonsh 0.16.0

commit d1e230a
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 11:22:01 2024 -0600

    Use the old xeus

commit eed485e
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 11:19:56 2024 -0600

    Use lp

commit e6574c4
Author: Ondřej Čertík <[email protected]>
Date:   Sat Jul 6 11:14:37 2024 -0600

    CI: switch to micromamba, update xeus
@Vipul-Cariappa
Implement Jupyter kernel
0856ac8
@Vipul-Cariappa
Test Kernel; presently it only builds, we should add tests later
b48e4e9
@Vipul-Cariappa
Copy link
Contributor Author

@certik, I have squash merged the changes make in #2762 and cherry-picked the necessery changes from #2756.

certik
certik reviewed Jul 8, 2024
View reviewed changes
src/lpython/python_evaluator.cpp
result.type = EvalResult::unsignedInteger2;
result.u32 = r;
} else {
int16_t r = e->execfn<int16_t>(run_fn);
int16_t r = e->execfn<int>(run_fn);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why the previous code was incorrect?

@certik certik marked this pull request as ready for review July 8, 2024 16:38
@certik
Copy link
Contributor

certik commented Jul 8, 2024

Looks like there is some issue with the bit_length implementation (#1836), so it's fine to disable the test. The other macOS interactive issue was fixed. I don't understand exactly the problem, but it looks like something with signed/unsigned. The change in this PR works on all platforms, so it gets us unblocked.

Let's merge it, and we can fix the rest of the issues later.

certik
certik reviewed Jul 8, 2024
View reviewed changes
@certik certik merged commit d26ce3a into lcompilers:main Jul 8, 2024
15 checks passed
@certik
Copy link
Contributor

certik commented Jul 8, 2024 •
edited
Loading

I am merged this as is, since all tests pass. Now I'll submit a PR to fix the package versions:

This was referenced Jul 8, 2024
Closed
Closed
Closed
Closed
Closed
@Vipul-Cariappa Vipul-Cariappa deleted the kernel-final branch July 9, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vipul-Cariappa @certik