Skip to content

Make runtime string comparison work #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Conversation

namannimmo10
Copy link
Collaborator

@namannimmo10 namannimmo10 commented Mar 8, 2022

No description provided.

@certik
Copy link
Contributor

certik commented Mar 8, 2022

Yes, the tricky part is to now insert these functions for string comparisons in ast to asr, but not for character comparison, as those have to be still handled by the backend, because the implementation of these functions uses it.

@namannimmo10
Copy link
Collaborator Author

I will have to see how to do that -- this can go in, though.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that this is good.

@certik certik merged commit 8dc7035 into lcompilers:main Mar 9, 2022
@namannimmo10 namannimmo10 deleted the strcmp branch March 9, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants