-
Notifications
You must be signed in to change notification settings - Fork 170
Implement round
built-in function
#199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good so far. |
Gives garbage values for the 6
I think that's because we are calling other built-in functions in our current runtime implementation. |
I usually get the function ( |
OK, this is ready for now; let me know if you have any suggestions or I'll merge this. Generic versions of these built-in functions will be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great!
We can implement a generic
round
onceoverload
is supported in LPython (#187), but for now this works for float arguments.TODO: