Reallocate LHS for allocatable strings #192
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If true, the LHS must be reallocated to the size of the RHS. If False, it is assumed to be allocated and of the right size.
|
The basic use case was fixed in #194, here we need to implement proper reallocation to actually free the memory correctly to fix all leaks. |
|
I think the way to do this initially is to have the Later, we can add optimizations to this scheme: each expression would have a tag if it owns the string or not. If it owns it and it's an expression, then "it goes out of scope" and must be deallocated. If it does not own it, then deallocation doesn't take place. I think we know at compile time who owns what. |
|
I think we need to work on this. @certik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.