Fix zero slice step #1879
Merged
Fix zero slice step #1879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!ASRUtils::is_integer(*ASRUtils::expr_type(ASRUtils::EXPR(tmp)))) { | ||
| throw SemanticError("slice indices must be integers or None", tmp->loc); | ||
| } | ||
| ASR::expr_t* val = ASRUtils::expr_value(ASRUtils::EXPR(tmp_step)); | ||
| if (val != nullptr && ASR::down_cast<ASR::IntegerConstant_t>(val)->m_n == 0) { |
There was a problem hiding this comment.
You can also use is_value_constant, but this is also fine, I think.
LGTM!
czgdp1807
requested changes
Jun 10, 2023
There was a problem hiding this comment.
Address https://github.com/lcompilers/lpython/pull/1879/files#r1217472487 and then it should be good.
czgdp1807
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1833.
I have added the check for any slice step. This holds for strings and lists.
Are there places where zero step is allowed? (I don't think so.)