Skip to content

ASR: Fix a bug in dict len #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2023
Merged

ASR: Fix a bug in dict len #1855

merged 3 commits into from
May 24, 2023

Conversation

Smit-create
Copy link
Collaborator

Fixes #1839

@Smit-create Smit-create added bug Something isn't working asr ASR related changes labels May 24, 2023
@Smit-create Smit-create requested review from czgdp1807 and certik May 24, 2023 13:43
@Smit-create Smit-create marked this pull request as ready for review May 24, 2023 14:57
certik
certik approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now. We can add a proper compile time implementation later.

I think the ASR::DictConstant_t should probably represent a proper dict at compile time, with the correct length. The same for Set. We can do that later.

@certik certik merged commit bac8685 into lcompilers:main May 24, 2023
@Smit-create Smit-create deleted the i-1839 branch May 24, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@czgdp1807 czgdp1807 Awaiting requested review from czgdp1807

Assignees
No one assigned
Labels
asr ASR related changes bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

len of Dictionaries handles repeated keys incorrectly
2 participants
@Smit-create @certik