Skip to content

Print error on assign to input parameter #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 23, 2023
Merged

Print error on assign to input parameter #1837

merged 5 commits into from
May 23, 2023

Conversation

Shaikh-Ubaid
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid commented May 20, 2023 •
edited
Loading

fixes #1784, #1807.

@Shaikh-Ubaid Shaikh-Ubaid requested a review from certik May 20, 2023 04:59
@Shaikh-Ubaid
Copy link
Collaborator Author

I think the CI test "Test PIP Installable Packages" might fail. Because, it tests integration_test/test_pip_import_01 which imports lpynn as well as lpython both of which are installed via pip and do not yet support the intent declaration syntax.

@Shaikh-Ubaid
Copy link
Collaborator Author

Let's complete #1838 first. So that we can then update the lpython_emulation package to support intent (and also remove goto).

@Shaikh-Ubaid Shaikh-Ubaid force-pushed the print_error_on_assign_to_input_param branch from c77e1f5 to 20f04f2 Compare May 23, 2023 15:36
@Shaikh-Ubaid Shaikh-Ubaid requested a review from czgdp1807 May 23, 2023 15:36
certik
certik approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Can you please also add a test for the error? It could be in a new PR.

@Shaikh-Ubaid Shaikh-Ubaid merged commit 0c8fbe0 into lcompilers:main May 23, 2023
@Shaikh-Ubaid Shaikh-Ubaid deleted the print_error_on_assign_to_input_param branch May 23, 2023 16:01
@Shaikh-Ubaid Shaikh-Ubaid mentioned this pull request May 23, 2023
Merged
@Shaikh-Ubaid
Copy link
Collaborator Author

Can you please also add a test for the error? It could be in a new PR.

Sure, submitted here #1852.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@czgdp1807 czgdp1807 Awaiting requested review from czgdp1807

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow parameter (argument) redefinition
2 participants
@Shaikh-Ubaid @certik