Skip to content

RTL: fix an issue with abs() #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2023
Merged

RTL: fix an issue with abs() #1835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions src/libasr/runtime/lfortran_intrinsics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,32 +794,44 @@ LFORTRAN_API char* _lfortran_int_to_str8(int64_t num)
LFORTRAN_API int32_t _lpython_bit_length1(int8_t num)
{
int32_t res = 0;
num = abs(num);
for(; num; num >>= 1, res++);
num = abs((int)num);
while (num > 0) {
num = num >> 1;
res++;
}
return res;
}

LFORTRAN_API int32_t _lpython_bit_length2(int16_t num)
{
int32_t res = 0;
num = abs(num);
for(; num; num >>= 1, res++);
num = abs((int)num);
while (num > 0) {
num = num >> 1;
res++;
}
return res;
}

LFORTRAN_API int32_t _lpython_bit_length4(int32_t num)
{
int32_t res = 0;
num = abs(num);
for(; num; num >>= 1, res++);
num = abs((int)num);
while (num > 0) {
num = num >> 1;
res++;
}
return res;
}

LFORTRAN_API int32_t _lpython_bit_length8(int64_t num)
{
int32_t res = 0;
num = llabs(num);
for(; num; num >>= 1, res++);
while (num > 0) {
num = num >> 1;
res++;
}
return res;
}

Expand Down Expand Up @@ -1114,7 +1126,7 @@ LFORTRAN_API int32_t _lfortran_ishft32(int32_t i, int32_t shift) {
if(shift > 0) {
return i << shift;
} else if(shift < 0) {
return i >> abs(shift);
return i >> abs((int)shift);
} else {
return i;
}
Expand Down