Sync `libasr` from LFortran #1670

czgdp1807 · 2023-04-06T05:08:12Z

Corresponding LFortran PR - lfortran/lfortran#1501

ubaidsk · 2023-04-06T06:36:39Z

For wasm, please include in this PR just the changes from lfortran/lfortran#1495, and then use the wasm and related files from lpython in lfortran. That would hopefully complete sync for wasm.

ubaidsk · 2023-04-06T06:40:30Z

src/libasr/alloc.h

+#ifdef LCOMPILERS_FAST_ALLOC
        try {
+#endif
            LCOMPILERS_ASSERT(start != nullptr);
            size_t addr = current_pos;
            current_pos += align(s);
-            if (size_current() > size_total()) throw std::bad_alloc();
+            if (size_current() > size_total()) {
+#ifdef LCOMPILERS_FAST_ALLOC
+                throw std::bad_alloc();
+#else
+                return new_chunk(s);
+#endif
+            }
            return (void*)addr;
+#ifdef LCOMPILERS_FAST_ALLOC
        } catch (const std::bad_alloc &e) {
            return new_chunk(s);
        }
+#endif


I think, this can be reverted for now. We can add it later when building lpython to wasm in release mode.

Sorry about this. LFortran needs it. Let's add it in LPython as well. (I assumed we could diverge here slightly and later make them same. Maybe its better to have equal LibASRs.)

ubaidsk · 2023-04-06T06:48:31Z

src/libasr/codegen/asr_to_julia.cpp

-        for (size_t idx=0; idx < s.size(); idx++) {
-            src += s[idx];
+        for (size_t idx = 0; idx < s.size(); idx++) {
+            if (s[idx] == '\n') {
+                src += "\\n";
+            } else if (s[idx] == '\\') {
+                src += "\\\\";
+            } else if (s[idx] == '\"') {
+                src += "\\\"";
+            } else {
+                src += s[idx];
+            }


I guess this needs to be reverted. Please see 3c53ffb.

ubaidsk · 2023-04-06T06:58:37Z

src/libasr/codegen/asr_to_x86.cpp

-        std::vector<std::string> build_order = ASRUtils::determine_module_dependencies(x);
-        for (auto &item : build_order) {
-            ASR::symbol_t *mod = x.m_global_scope->get_symbol(item);
-            visit_symbol(*mod);
-        }
-


I think this needs to be reverted (39aed26).

ubaidsk · 2023-04-06T06:58:57Z

src/libasr/codegen/asr_to_x86.cpp

-    void visit_Module(const ASR::Module_t &x) {
-        std::vector<std::string> func_order
-            = ASRUtils::determine_function_definition_order(x.m_symtab);
-        for (size_t i = 0; i < func_order.size(); i++) {
-            ASR::symbol_t* sym = x.m_symtab->get_symbol(func_order[i]);
-            // Ignore external symbols because they are already defined by the loop above.
-            if( !sym || ASR::is_a<ASR::ExternalSymbol_t>(*sym) ) {
-                continue;
-            }
-            visit_symbol(*sym);
-        }
-    }
-


to be reverted (39aed26)

ansharlubis · 2023-04-06T06:59:03Z

Looks good here in the generics department.

ubaidsk · 2023-04-06T07:05:26Z

src/libasr/pass/pass_list_expr.cpp

-        std::string list_type_name = ASRUtils::get_type_code(list_type, true);
+        std::string list_type_name = ASRUtils::type_to_str_python(list_type);


I think this needs to be reverted. Please see a166236.

ubaidsk · 2023-04-06T07:05:51Z

src/libasr/pass/pass_list_expr.cpp

-        std::string list_type_name = ASRUtils::get_type_code(x->m_type, true);
+        std::string list_type_name = ASRUtils::type_to_str_python(x->m_type);


to be reverted. (a166236)

ubaidsk · 2023-04-06T07:06:12Z

src/libasr/pass/pass_list_expr.cpp

-        std::string list_type_name = ASRUtils::get_type_code(list_type, true);
+        std::string list_type_name = ASRUtils::type_to_str_python(list_type);


Similarly, here (a166236)

ubaidsk · 2023-04-06T07:06:36Z

src/libasr/pass/pass_list_expr.cpp

-        std::string list_type_name =  ASRUtils::get_type_code(x->m_type, true);
+        std::string list_type_name = ASRUtils::type_to_str_python(x->m_type);


Similarly here (a166236)

ubaidsk · 2023-04-06T07:16:46Z

src/libasr/codegen/asr_to_llvm.cpp

-    llvm::Value* lfortran_str_item(llvm::Value* str, llvm::Value* idx1)
+    llvm::Value* lfortran_str_copy(llvm::Value* str, llvm::Value* idx1, llvm::Value* idx2)
    {
-        std::string runtime_func_name = "_lfortran_str_item";
+        std::string runtime_func_name = "_lfortran_str_copy";
        llvm::Function *fn = module->getFunction(runtime_func_name);
        if (!fn) {
            llvm::FunctionType *function_type = llvm::FunctionType::get(
                    character_type, {
-                        character_type, llvm::Type::getInt32Ty(context)
+                        character_type, llvm::Type::getInt32Ty(context), llvm::Type::getInt32Ty(context)
                    }, false);
            fn = llvm::Function::Create(function_type,
                    llvm::Function::ExternalLinkage, runtime_func_name, *module);
        }
-        return builder->CreateCall(fn, {str, idx1});
+        return builder->CreateCall(fn, {str, idx1, idx2});
    }


I think this needs to be reverted. Please see 2f45421.

ubaidsk · 2023-04-06T07:17:25Z

src/libasr/codegen/asr_to_llvm.cpp

-                p = lfortran_str_item(str, idx);
+                p = lfortran_str_copy(str, idx, idx);


to be reverted (2f45421)

ubaidsk · 2023-04-06T07:19:22Z

src/libasr/codegen/asr_to_llvm.cpp

-        llvm::Value *step = llvm::ConstantInt::get(context, llvm::APInt(32, 1));
-        llvm::Value *present = llvm::ConstantInt::get(context, llvm::APInt(1, 1));
-        llvm::Value *p = lfortran_str_slice(str, idx1, idx2, step, present, present);
+        llvm::Value *p = lfortran_str_copy(str, idx1, idx2);


to be reverted (2f45421)

ubaidsk · 2023-04-06T07:28:19Z

src/libasr/codegen/asr_to_llvm.cpp

-        tmp = lfortran_str_item(str, idx);
+        tmp = lfortran_str_copy(str, idx, idx);


to be reverted (2f45421).

ubaidsk · 2023-04-06T07:29:26Z

src/libasr/codegen/asr_to_llvm.cpp

-    // std::cout << LPython::pickle(asr, true, true, true) << std::endl;
+    // std::cout << LFortran::pickle(asr, true, true, true) << std::endl;


Can be reverted.

ubaidsk · 2023-04-06T07:44:04Z

I guess we missed to include write_array_using_doloop() in pass/print_arr.cpp. It was added in lfortran in lfortran/lfortran@b1992c3.

ubaidsk · 2023-04-06T07:47:19Z

src/libasr/wasm_instructions_visitor.py

-    def visit_BaseWASMVisitor(self, mod, *args):
+    def visitWASMInstructions(self, mod, *args):


This whole file needs to be reverted. Please see my comment here #1670 (comment).

I did and now I am getting the following errors,

Consolidate compiler generated dependencies of target asr [ 1%] Building CXX object src/libasr/CMakeFiles/asr.dir/codegen/wasm_to_wat.cpp.o In file included from /Users/czgdp1807/lpython_project/lpython/src/libasr/codegen/wasm_to_wat.cpp:5: In file included from /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/codegen/wasm_to_wat.h:4: /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2794:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, labelidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2799:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, labelidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2808:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, funcidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2813:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, typeidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2814:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, tableidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2819:15: error: no member named 'emit_b8' in namespace 'LCompilers::wasm' wasm::emit_b8(m_code, m_al, reftype); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2828:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, funcidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2841:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, localidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2846:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, localidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2851:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, localidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2856:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, globalidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2861:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, globalidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2866:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, tableidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2871:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, tableidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2876:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, mem_align); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2877:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, mem_offset); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2882:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, mem_align); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2883:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, mem_offset); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2888:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, mem_align); ~~~~~~^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated. make[2]: *** [src/libasr/CMakeFiles/asr.dir/build.make:174: src/libasr/CMakeFiles/asr.dir/codegen/wasm_to_wat.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:287: src/libasr/CMakeFiles/asr.dir/all] Error 2 make: *** [Makefile:166: all] Error 2 (lp) 15:18:20:~/lpython_project/lpython % ./build0.sh + ci/version.sh ++ git describe --tags --dirty + version=v0.12.0-239-gb35e744dc-dirty + version=0.12.0-239-gb35e744dc-dirty + echo 0.12.0-239-gb35e744dc-dirty + python grammar/asdl_py.py Assuming default values of Python.asdl and python_ast.py + python src/libasr/asdl_cpp.py grammar/Python.asdl src/lpython/python_ast.h + python src/libasr/asdl_cpp.py src/libasr/ASR.asdl src/libasr/asr.h + python src/libasr/wasm_instructions_visitor.py Assuming default values of wasm_instructions.txt and wasm_visitor.h + cd src/lpython/parser + re2c -W -b tokenizer.re -o tokenizer.cpp + cd src/lpython/parser + bison -Wall -d -r all parser.yy + grep -n ''\''' src/lpython/parser/parser.yy + echo OK OK (lp) 15:18:46:~/lpython_project/lpython % make Consolidate compiler generated dependencies of target asr [ 1%] Building CXX object src/libasr/CMakeFiles/asr.dir/codegen/asr_to_cpp.cpp.o [ 2%] Building CXX object src/libasr/CMakeFiles/asr.dir/codegen/asr_to_c.cpp.o [ 3%] Building CXX object src/libasr/CMakeFiles/asr.dir/codegen/asr_to_julia.cpp.o [ 4%] Building CXX object src/libasr/CMakeFiles/asr.dir/codegen/asr_to_py.cpp.o [ 5%] Building CXX object src/libasr/CMakeFiles/asr.dir/codegen/asr_to_x86.cpp.o [ 7%] Building CXX object src/libasr/CMakeFiles/asr.dir/codegen/asr_to_wasm.cpp.o [ 8%] Building CXX object src/libasr/CMakeFiles/asr.dir/codegen/wasm_to_wat.cpp.o In file included from /Users/czgdp1807/lpython_project/lpython/src/libasr/codegen/wasm_to_wat.cpp:5: In file included from /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/codegen/wasm_to_wat.h:4: /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2794:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, labelidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2799:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, labelidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2808:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, funcidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2813:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, typeidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2814:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, tableidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2819:15: error: no member named 'emit_b8' in namespace 'LCompilers::wasm' wasm::emit_b8(m_code, m_al, reftype); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2828:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, funcidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2841:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, localidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2846:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, localidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2851:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, localidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2856:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, globalidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2861:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, globalidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2866:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, tableidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2871:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, tableidx); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2876:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, mem_align); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2877:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, mem_offset); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2882:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, mem_align); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2883:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, mem_offset); ~~~~~~^ /Users/czgdp1807/lpython_project/lpython/src/libasr/../libasr/wasm_visitor.h:2888:15: error: no member named 'emit_u32' in namespace 'LCompilers::wasm' wasm::emit_u32(m_code, m_al, mem_align); ~~~~~~^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated. make[2]: *** [src/libasr/CMakeFiles/asr.dir/build.make:174: src/libasr/CMakeFiles/asr.dir/codegen/wasm_to_wat.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:287: src/libasr/CMakeFiles/asr.dir/all] Error 2 make: *** [Makefile:166: all] Error 2

Resolved. Thanks.

ubaidsk · 2023-04-06T08:11:24Z

The rest looks good to me. Thank you so much for this PR.

Smit-create · 2023-04-06T08:15:37Z

src/libasr/runtime/lfortran_intrinsics.c

-// idx starts from 1
-LFORTRAN_API char* _lfortran_str_item(char* s, int32_t idx) {
+// idx1 and idx2 both start from 1
+LFORTRAN_API char* _lfortran_str_copy(char* s, int32_t idx1, int32_t idx2) {


Needs to be reverted 2f45421

Pranavchiku · 2023-04-06T09:52:08Z

I guess change of pass/implied_do_loops.cpp are missed, lfortran/lfortran@3e69b8d.

czgdp1807 · 2023-04-06T09:54:08Z

For wasm, please include in this PR just the changes from lfortran/lfortran#1495, and then use the wasm and related files from lpython in lfortran. That would hopefully complete sync for wasm.

They are already there in this PR.

czgdp1807 · 2023-04-06T09:55:32Z

I guess change of pass/implied_do_loops.cpp are missed, lfortran/lfortran@3e69b8d.

The commit you have mentioned is a very old one. implied_do_loops.cpp was revamped afterwards.

Pranavchiku · 2023-04-06T10:03:04Z

src/libasr/pass/print_arr.cpp

@@ -85,7 +85,7 @@ class PrintArrVisitor : public PassUtils::PassVisitor<PrintArrVisitor>
                doloop_body.push_back(al, doloop);
                doloop_body.push_back(al, empty_print_endl);
            }
-            doloop = ASRUtils::STMT(ASR::make_DoLoop_t(al, loc, head, doloop_body.p, doloop_body.size()));
+            doloop = ASRUtils::STMT(ASR::make_DoLoop_t(al, loc, nullptr, head, doloop_body.p, doloop_body.size()));


Changes in pass/print_arr.cpp are missing, lfortran/lfortran@b1992c3

Yup, I shared here #1670 (comment).

Again, that's a very old commit. I just copied today mornings main from lfortran into lpython.

It is there in the latest main as well.

https://github.com/lfortran/lfortran/blob/main/src/libasr/pass/print_arr.cpp#L138

Yes. I added it in this PR.

ubaidsk · 2023-04-06T10:14:10Z

For wasm, please include in this PR just the changes from lfortran/lfortran#1495, and then use the wasm and related files from lpython in lfortran. That would hopefully complete sync for wasm.

They are already there in this PR.

Please consider the wasm and related files at lpython, current main branch to be the latest/ultimate version. And to this latest version we just need to add the changes in lfortran/lfortran#1495. Now, the wasm and related files are fully synced (for lpython).

We now copy these files from lpython and paste/replace in lfortran. Please let me know if it is clear. Also, please let me know if I shall make the above change.

Pranavchiku

One or two commits are missing, rest all look good to me. Thanks for syncing!

czgdp1807 · 2023-04-06T10:47:27Z

@Shaikh-Ubaid WASM fails on CI. Could you please take a look?

17/33 Test #22: test_complex_01 ..................***Failed    0.28 sec
(node:15485) ExperimentalWarning: WASI is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[CompileError: WebAssembly.compile(): Compiling function #15 failed: function index #4294967295 is out of bounds @+2470]

ubaidsk · 2023-04-06T11:34:46Z

src/libasr/codegen/asr_to_x86.cpp

-        ASR::Function_t *s = ASR::down_cast<ASR::Function_t>(
-            ASRUtils::symbol_get_past_external(x.m_name));
+        ASR::Function_t *s = ASR::down_cast<ASR::Function_t>(x.m_name);


I think/guess this needs to be reverted (39aed26).

Thirumalai-Shaktivel · 2023-04-07T02:58:21Z

src/libasr/codegen/asr_to_llvm.cpp

-        std::string s = unescape_string(al, x.m_s);
-        tmp = builder->CreateGlobalStringPtr(s);
+        tmp = builder->CreateGlobalStringPtr(x.m_s);


To be reverted, I think. Can you please add this LFortran as well!

https://github.com/lcompilers/lpython/pull/1502/files

Thirumalai-Shaktivel · 2023-04-07T03:00:37Z

src/libasr/codegen/asr_to_llvm.cpp

-                ASR::StructType_t* der_type = ASR::down_cast<ASR::StructType_t>(
-                    ASRUtils::symbol_get_past_external(der->m_derived_type));
+                ASR::Struct_t* der = (ASR::Struct_t*)(&(x->m_type->base));
+                ASR::StructType_t* der_type = (ASR::StructType_t*)(&(der->m_derived_type->base));


To be reverted, I think.
https://github.com/lcompilers/lpython/pull/1579/files#diff-48a7161397f9eb8b730f0cbec2f11ce1471aac961dc6b16dc558cf161c375054R5566

Thirumalai-Shaktivel

Apart from the above changes. I think this looks good to go in.
Thank you very much!

Pranavchiku

LGTM! Thanks for doing this!

Thirumalai-Shaktivel · 2023-04-07T06:43:56Z

src/libasr/codegen/asr_to_llvm.cpp

-                ASR::Class_t* der = ASR::down_cast<ASR::Class_t>(x->m_type);
-                ASR::ClassType_t* der_type = ASR::down_cast<ASR::ClassType_t>(
-                    ASRUtils::symbol_get_past_external(der->m_class_type));
+                ASR::Class_t* der = (ASR::Class_t*)(&(x->m_type->base));
+                ASR::ClassType_t* der_type = (ASR::ClassType_t*)(&(der->m_class_type->base));


Sorry, I didn't mention this earlier. Can you please revert this as well.

Co-authored-by: Shaikh Ubaid <[email protected]>

czgdp1807 force-pushed the libasr_sync_02 branch from cf9ae06 to b2186ca Compare April 6, 2023 05:37

czgdp1807 mentioned this pull request Apr 6, 2023

ASR: Sync Libasr from LFortran #1658

Closed

ubaidsk reviewed Apr 6, 2023

View reviewed changes

Smit-create reviewed Apr 6, 2023

View reviewed changes

Pranavchiku reviewed Apr 6, 2023

View reviewed changes

Pranavchiku requested changes Apr 6, 2023

View reviewed changes

czgdp1807 force-pushed the libasr_sync_02 branch from b2186ca to b6af4d9 Compare April 6, 2023 10:33

ubaidsk reviewed Apr 6, 2023

View reviewed changes

czgdp1807 force-pushed the libasr_sync_02 branch from ec46820 to 85eadac Compare April 6, 2023 12:34

czgdp1807 mentioned this pull request Apr 6, 2023

Sync libasr from LPython lfortran/lfortran#1501

Merged

czgdp1807 marked this pull request as ready for review April 6, 2023 17:46

ubaidsk force-pushed the libasr_sync_02 branch from c132211 to f9b5028 Compare April 7, 2023 01:21

Thirumalai-Shaktivel reviewed Apr 7, 2023

View reviewed changes

Thirumalai-Shaktivel approved these changes Apr 7, 2023

View reviewed changes

Pranavchiku approved these changes Apr 7, 2023

View reviewed changes

czgdp1807 force-pushed the libasr_sync_02 branch from f9b5028 to 6ecf957 Compare April 7, 2023 05:14

Smit-create approved these changes Apr 7, 2023

View reviewed changes

Thirumalai-Shaktivel reviewed Apr 7, 2023

View reviewed changes

ubaidsk approved these changes Apr 7, 2023

View reviewed changes

czgdp1807 force-pushed the libasr_sync_02 branch from 6ecf957 to a662011 Compare April 7, 2023 10:25

czgdp1807 and others added 2 commits April 7, 2023 16:13

Sync libasr from LFortran

35a8d86

Co-authored-by: Shaikh Ubaid <[email protected]>

Updated reference tests

43b0188

czgdp1807 force-pushed the libasr_sync_02 branch from a662011 to 43b0188 Compare April 7, 2023 10:45

czgdp1807 requested a review from certik April 7, 2023 15:46

certik approved these changes Apr 7, 2023

View reviewed changes

certik merged commit c313b33 into lcompilers:main Apr 7, 2023

ubaidsk mentioned this pull request Apr 8, 2023

Add back LCOMPILERS_FAST_ALLOC #ifdef #1682

Merged

		std::string list_type_name = ASRUtils::get_type_code(list_type, true);
		std::string list_type_name = ASRUtils::type_to_str_python(list_type);

		p = lfortran_str_item(str, idx);
		p = lfortran_str_copy(str, idx, idx);

		tmp = lfortran_str_item(str, idx);
		tmp = lfortran_str_copy(str, idx, idx);

		// std::cout << LPython::pickle(asr, true, true, true) << std::endl;
		// std::cout << LFortran::pickle(asr, true, true, true) << std::endl;

		def visit_BaseWASMVisitor(self, mod, *args):
		def visitWASMInstructions(self, mod, *args):

Sync libasr from LFortran #1670

Sync libasr from LFortran #1670

Uh oh!

Conversation

czgdp1807 commented Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ubaidsk commented Apr 6, 2023

Uh oh!

ubaidsk Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ubaidsk Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ubaidsk Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ansharlubis commented Apr 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ubaidsk Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ubaidsk commented Apr 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ubaidsk commented Apr 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pranavchiku commented Apr 6, 2023

Uh oh!

czgdp1807 commented Apr 6, 2023

Uh oh!

czgdp1807 commented Apr 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ubaidsk commented Apr 6, 2023

Uh oh!

Pranavchiku left a comment

Sync `libasr` from LFortran #1670

Sync `libasr` from LFortran #1670

czgdp1807 commented Apr 6, 2023 •

edited

Loading

ubaidsk Apr 6, 2023 •

edited

Loading

ubaidsk Apr 6, 2023 •

edited

Loading

ubaidsk Apr 6, 2023 •

edited

Loading

ubaidsk Apr 6, 2023 •

edited

Loading

ubaidsk Apr 6, 2023 •

edited

Loading