Skip to content

Add missing imports to the integration tests #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 1, 2023
Merged

Add missing imports to the integration tests #1655

merged 10 commits into from
Apr 1, 2023

Conversation

khairalanam
Copy link
Contributor

This PR adds missing imports to many of the integration tests.

The reference tests are updated successfully without any errors.

@czgdp1807 czgdp1807 enabled auto-merge (squash) April 1, 2023 06:25
Thirumalai-Shaktivel
Thirumalai-Shaktivel reviewed Apr 1, 2023
View reviewed changes
tests/reference/runtime-test_list_01-3ee9b3e.stdout Outdated
@@ -0,0 +1 @@
The command 'link /NOLOGO /OUT:test_list_01.out test_list_01.out.tmp.o $DIR\src\bin/../runtime\lpython_runtime_static.lib > NUL' failed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes has to be removed!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files were unused anyways I guess. Check 4597374

@Thirumalai-Shaktivel
Copy link
Collaborator

@khairalanam for updating tests in Windows, please do: python run_tests.py -u --skip-run-with-dbg

@khairalanam
Copy link
Contributor Author

@khairalanam for updating tests in Windows, please do: python run_tests.py -u --skip-run-with-dbg

I ran this command for updating the tests for this PR.

@khairalanam
Copy link
Contributor Author

Should I run the command again?

@Thirumalai-Shaktivel
Copy link
Collaborator

I see, there seems to be some problem in the Windows, we have to debug that!
Do this, just to revert the runtime-test_list_01_*.stdout and runtime-test_list_02_*.stdout changes. Then I think this PR is good to go in.

@khairalanam
Copy link
Contributor Author

I see, there seems to be some problem in the Windows, we have to debug that! Do this, just to revert the runtime-test_list_01_*.stdout and runtime-test_list_02_*.stdout changes. Then I think this PR is good to go in.

Can this be done manually?

@czgdp1807 czgdp1807 enabled auto-merge (squash) April 1, 2023 09:38
@czgdp1807 czgdp1807 merged commit 15ab2bf into lcompilers:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgdp1807 czgdp1807 czgdp1807 left review comments

@Thirumalai-Shaktivel Thirumalai-Shaktivel Thirumalai-Shaktivel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khairalanam @Thirumalai-Shaktivel @czgdp1807