Skip to content

ASR Pass: Fix variables names to be used in C backend #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2023
Merged

ASR Pass: Fix variables names to be used in C backend #1592

merged 3 commits into from
Mar 20, 2023

Conversation

Smit-create
Copy link
Collaborator

@Smit-create Smit-create requested a review from certik March 20, 2023 06:29
@Smit-create Smit-create marked this pull request as ready for review March 20, 2023 08:34
@Smit-create Smit-create added c Label for C language related changes asr_pass ASR pass related changes labels Mar 20, 2023
certik
certik approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now, although a more general approach might be needed regarding what is allowed as a symbol name in ASR, and then "escape" it properly in the backends.

@Smit-create Smit-create merged commit 37918fa into lcompilers:main Mar 20, 2023
@Smit-create Smit-create deleted the i-1575-2 branch March 20, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
asr_pass ASR pass related changes c Label for C language related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smit-create @certik