Skip to content

Implement floordiv for i16 and i8 #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2023
Merged

Implement floordiv for i16 and i8 #1587

merged 3 commits into from
Mar 17, 2023

Conversation

certik
Copy link
Contributor

@certik certik commented Mar 17, 2023

Add an integration test.

Fixes #1586.

@certik certik requested a review from Smit-create March 17, 2023 03:36
@certik
Split expr_04 into expr_15
860d530 
That way the WASM backend keeps working.
Smit-create
Smit-create approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@Smit-create Smit-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We can try using generics later. Thank you!

@certik certik merged commit 5ccc09c into lcompilers:main Mar 17, 2023
@certik certik deleted the floordiv branch March 17, 2023 16:21
@certik
Copy link
Contributor Author

certik commented Mar 17, 2023

Thanks @Smit-create. Indeed, or add this function to IntrinsicFunction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smit-create Smit-create Smit-create approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support // for i16
2 participants
@certik @Smit-create