WASM: Support bitwise operations #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubaidsk
force-pushed
the
wasm_bitoperations
branch
from
d982f88 to
725a580
Compare
ubaidsk
commented
Jan 24, 2023
Comment on lines
+967
to
+968
| // there is no direct bit-invert inst in wasm, | ||
| // so xor-ing with -1 (sequence of 32/64 1s) |
There was a problem hiding this comment.
More Info: WebAssembly/design#379
|
For |
|
This is ready. Please possibly review and share feedback. |
certik
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for bitwise operators in the
wasmbackend.