[LLVM]: Implement Tuple/List Compare #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
reviewed
Dec 14, 2022
| @@ -129,7 +129,6 @@ namespace LCompilers { | |||
| "select_case", | |||
| "inline_function_calls", | |||
| "unused_functions", | |||
| "pass_compare" | |||
There was a problem hiding this comment.
Probably this means we need backend specific list of passes. Because C/C++/Julia will need this pass but LLVM won't.
czgdp1807
reviewed
Dec 14, 2022
| ASRUtils::expr_type(x.m_left)); | ||
| if (x.m_op == ASR::cmpopType::NotEq) { | ||
| tmp = builder->CreateNot(tmp); | ||
| } |
There was a problem hiding this comment.
This seems good to me. Is this working?
There was a problem hiding this comment.
Yes, TupleCompare works fine. I will need to add the ListCompare to make the CI pass.
Smit-create
force-pushed
the
i-1245-2
branch
2 times, most recently
from
270c5d8 to
0fa8423
Compare
Smit-create
force-pushed
the
i-1245-2
branch
from
ea6653f to
d69020c
Compare
|
The tests pass locally for me as well as on ubuntu CI. Not sure why does that segfault on macos |
Smit-create
force-pushed
the
i-1245-2
branch
from
d69020c to
2ed28bc
Compare
|
@czgdp1807 @certik This is ready for review. |
Smit-create
added
ready for review
Smit-create
force-pushed
the
i-1245-2
branch
from
2ed28bc to
892b085
Compare
certik
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1245
Completes #1342 (comment)