Modify the handling of exit code in lpython.cpp #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
reviewed
Dec 13, 2022
src/bin/lpython.cpp
Outdated
| @@ -1657,6 +1657,8 @@ int main(int argc, char *argv[]) | |||
| if (err != 0) { | |||
| if (0 < err && err < 256) { | |||
| return err; | |||
| } else if (err % 256 == 0) { | |||
| return err / 256; | |||
There was a problem hiding this comment.
What does this do exactly? Let's document it in a comment.
There was a problem hiding this comment.
In Linux, the exit values are multiplied by 256
https://stackoverflow.com/a/3736358
https://unix.stackexchange.com/questions/394639/why-do-high-exit-codes-on-linux-shells-256-not-work-as-expected
So, when we do:
quit(10)>> echo $?
2560
Thirumalai-Shaktivel
force-pushed
the
exit_code
branch
from
4d128d0 to
a29c095
Compare
certik
reviewed
Dec 21, 2022
src/bin/lpython.cpp
Outdated
| return 1; | ||
| // https://stackoverflow.com/a/27117435/15913193 | ||
| // https://linux.die.net/man/3/system | ||
| return WEXITSTATUS(err); |
There was a problem hiding this comment.
This does not compile on Windows:
D:\a\lpython\lpython\lpython-0.8.0-14-gb2d00ab00\src\bin\lpython.cpp(1663): error C3861: 'WEXITSTATUS': identifier not found
Thirumalai-Shaktivel
force-pushed
the
exit_code
branch
from
0e99951 to
7a80bd2
Compare
certik
reviewed
Dec 28, 2022
src/bin/lpython.cpp
Outdated
| @@ -1658,7 +1658,9 @@ int main(int argc, char *argv[]) | |||
| if (0 < err && err < 256) { | |||
| return err; | |||
| } else { | |||
| return 1; | |||
| // https://stackoverflow.com/a/27117435/15913193 | |||
| // https://linux.die.net/man/3/system | |||
There was a problem hiding this comment.
Move these two links into the utils.cpp file to document get_exit_status?
certik
approved these changes
Dec 28, 2022
certik
reviewed
Dec 28, 2022
| @@ -12,6 +12,8 @@ std::string get_runtime_library_header_dir(); | |||
| bool is_directory(std::string path); | |||
| bool path_exists(std::string path); | |||
|
|
|||
| int32_t get_exit_status(int32_t err); | |||
There was a problem hiding this comment.
Document here what the function does, you can put the links above here as well.
|
Thanks for the approval. Let's merge this. |
Thirumalai-Shaktivel
force-pushed
the
exit_code
branch
from
5c7c4eb to
a814362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1316