Fix tuple arguments type in function #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
requested changes
Dec 4, 2022
src/libasr/codegen/asr_to_llvm.cpp
Outdated
| @@ -2984,7 +2984,8 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor<ASRToLLVMVisitor> | |||
| ASR::storage_typeType local_m_storage = ASR::storage_typeType::Default; | |||
| llvm_el_types.push_back(get_arg_type_from_ttype_t(asr_tuple->m_type[i], m_abi, | |||
| arg_m_abi, local_m_storage, arg_m_value_attr, local_n_dims, | |||
| local_a_kind, is_local_array_type, ASRUtils::intent_local)); | |||
| local_a_kind, is_local_array_type, | |||
| ASRUtils::intent_local)->getPointerElementType()); | |||
There was a problem hiding this comment.
You can't use getPointerElementType (not allowed from LLVM 15 onwards). So please figure out a different way to achieve the same goal that you are trying to by using this API.
czgdp1807
reviewed
Dec 4, 2022
src/libasr/codegen/asr_to_llvm.cpp
Outdated
| arg_m_abi, local_m_storage, arg_m_value_attr, local_n_dims, | ||
| local_a_kind, is_local_array_type, | ||
| ASRUtils::intent_local)->getPointerElementType()); | ||
| llvm_el_types.push_back(get_type_from_ttype_t(asr_tuple->m_type[i], |
There was a problem hiding this comment.
You can use get_type_from_ttype_t_util as well. It won't require you to declare auxiliary argument variables.
There was a problem hiding this comment.
Thanks! Updated
|
What is the status of this? @czgdp1807 can you please review? |
|
Already reviewed. See #1349 (comment). Waiting for @Smit-create to update. |
certik
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1348