Skip to content

Handle structs as return type in C and LLVM backends #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

czgdp1807
Copy link
Collaborator

No description provided.

@czgdp1807 czgdp1807 marked this pull request as ready for review November 11, 2022 10:43
{
if( _ ) {

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

I recommend not using default arguments, and just use bool /* arg_name */.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@czgdp1807
Copy link
Collaborator Author

I will be implementing the actual solution for struct return types which we discussed in #1289. I am converting this to draft for now.

@czgdp1807 czgdp1807 marked this pull request as draft November 13, 2022 14:36
@czgdp1807
Copy link
Collaborator Author

Closing in favour of #1295

@czgdp1807 czgdp1807 closed this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants