Skip to content

WASM_X86: Combine X86Generator and X86Visitor Classes #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2022
Merged

WASM_X86: Combine X86Generator and X86Visitor Classes #1257

merged 1 commit into from
Nov 3, 2022

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Nov 2, 2022 •
edited
Loading

This PR combines the classes X86Generator of wasm_to_x86.cpp and X86Visitor of wasm_to_x86.h to a single class X86Visitor in wasm_to_x86.cpp.

This single class X86Visitor inherits from both the classes WASMDecoder and BaseWASMVisitor.

This was referenced Nov 2, 2022
Merged
Closed
@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Nov 2, 2022

This is ready. Please possibly review and please share feedback.

@ubaidsk ubaidsk requested a review from certik November 2, 2022 20:00
certik
certik approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine with me. If you like this version better, then go ahead and merge.

@ubaidsk ubaidsk merged commit 368063b into lcompilers:main Nov 3, 2022
@ubaidsk ubaidsk deleted the wasm_x86_combine_x86visitor_x86generator branch November 3, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubaidsk @certik