Skip to content

Strings methods: find() #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Conversation

AbdelrahmanKhaledd
Copy link
Collaborator

No description provided.

@AbdelrahmanKhaledd AbdelrahmanKhaledd force-pushed the str@find branch 2 times, most recently from f616e0b to 2ff9022 Compare August 24, 2022 13:17
@AbdelrahmanKhaledd
Copy link
Collaborator Author

Ready for review @certik @czgdp1807

@AbdelrahmanKhaledd AbdelrahmanKhaledd force-pushed the str@find branch 2 times, most recently from 9932ff8 to 90a2ec4 Compare August 25, 2022 01:08
@certik certik requested a review from czgdp1807 August 27, 2022 19:25
Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the conflicts and clean up the git history. See https://github.com/lcompilers/lpython/blob/main/doc/src/rebasing.md#merging for steps.

@AbdelrahmanKhaledd
Copy link
Collaborator Author

@czgdp1807 Done!

@AbdelrahmanKhaledd
Copy link
Collaborator Author

@czgdp1807 ready now!

assert s.find('B') == 6
assert "empty strings" .find("string") == 6
s2: str
s2 = "Ferrars all spirits his imagine effects amongst neither. It bachelor cheerful of mistaken. Tore has sons put upon wife use bred seen. Its dissimilar invitation ten has discretion unreserved. Had you him humoured jointure ask expenses learning. Blush on in jokes sense do do. Brother hundred he assured reached on up no. On am nearer missed lovers. To it mother extent temper figure better."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the source of this string?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from https://www.rs-niers-mg.de/breaking-bad-illustrated/?

Well copying a string from a website makes us prone to copyright claims. Can you just write something of your own? Like just take this review comment and put it as a string?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's from a text generator, but i will change it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czgdp1807
ready now.

@czgdp1807 czgdp1807 merged commit ffd9b05 into lcompilers:main Sep 2, 2022
@AbdelrahmanKhaledd AbdelrahmanKhaledd deleted the str@find branch September 2, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants