Generate the runtime_stacktrace related files during the compile-time

Author: Thirumalai-Shaktivel

src/bin/lpython.cpp

@@ -1638,6 +1638,29 @@ int main(int argc, char *argv[])
                 err = link_executable({tmp_o}, outfile, runtime_library_dir,
                     backend, static_link, true, compiler_options);
                 if (err != 0) return err;
+
+                if (compiler_options.emit_debug_info) {
+                    // TODO: Replace the following hardcoded part
+                    std::string cmd = "";
+#ifdef HAVE_LFORTRAN_MACHO
+                    cmd += "dsymutil " + basename + ".out && llvm-dwarfdump --debug-line "
+                        + basename + ".out.dSYM > ";
+#else
+                    cmd += "llvm-dwarfdump --debug-line " + basename + ".out > ";
+#endif
+                    cmd += basename + "_ldd.txt && (cd src/bin; ./dwarf_convert.py ../../"
+                        + basename + "_ldd.txt ../../" + basename + "_lines.txt ../../"
+                        + basename + "_lines.dat && ./dat_convert.py ../../"
+                        + basename + "_lines.dat)";
+                    int status = system(cmd.c_str());
+                    if ( status != 0 ) {
+                        std::cerr << "Error in creating the files used to generate "
+                            "the debug information. This might be caused because either"
+                            "`llvm-dwarfdump` or `Python` are not available. "
+                            "Please activate the CONDA environment and compile again.\n";
+                        return status;
+                    }
+                }
 #else
                 std::cerr << "Compiling Python files to object files requires the LLVM backend to be enabled. Recompile with `WITH_LLVM=yes`." << std::endl;
                 return 1;

src/libasr/runtime/lfortran_intrinsics.c

@@ -10,7 +10,7 @@
 #include <limits.h>
 #include <ctype.h>
 
-#include <libasr/runtime/lfortran_intrinsics.h>w
+#include <libasr/runtime/lfortran_intrinsics.h>
 #include <libasr/config.h>
 
 #ifdef HAVE_RUNTIME_STACKTRACE
@@ -1501,78 +1501,45 @@ char *remove_whitespace(char *str) {
     return str;
 }
 
-int generate_stacktrace_files() {
-    // TODO: Replace the hardcoded part
-    char *base_name = get_base_name(source_filename);
-    char *cmd = malloc(strlen(base_name)*7 + 200);
-#ifdef HAVE_LFORTRAN_MACHO
-    strcpy(cmd, "dsymutil ");
-    strcat(cmd, base_name);
-    strcat(cmd, ".out && llvm-dwarfdump --debug-line ");
-    strcat(cmd, base_name);
-    strcat(cmd, ".out.dSYM > ");
-#else
-    strcpy(cmd, "llvm-dwarfdump --debug-line ");
-    strcat(cmd, base_name);
-    strcat(cmd, ".out > ");
-#endif
-    strcat(cmd, base_name);
-    strcat(cmd, "_ldd.txt && (cd src/bin; ./dwarf_convert.py ../../");
-    strcat(cmd, base_name);
-    strcat(cmd, "_ldd.txt ../../");
-    strcat(cmd, base_name);
-    strcat(cmd, "_lines.txt ../../");
-    strcat(cmd, base_name);
-    strcat(cmd, "_lines.dat && ./dat_convert.py ../../");
-    strcat(cmd, base_name);
-    strcat(cmd, "_lines.dat)");
-    int status = system(cmd);
-    free(cmd);
-    return status;
-}
-
 LFORTRAN_API void print_stacktrace_addresses(char *filename, bool use_colors) {
     source_filename = filename;
-    int status = generate_stacktrace_files();
-    if (status == 0) {
-        struct Stacktrace d = get_stacktrace_addresses();
-        get_local_address(&d);
-        get_local_info_dwarfdump(&d);
+    struct Stacktrace d = get_stacktrace_addresses();
+    get_local_address(&d);
+    get_local_info_dwarfdump(&d);
 
 #ifdef HAVE_LFORTRAN_MACHO
-        for (int32_t i = d.local_pc_size-2; i > 1; i--) {
+    for (int32_t i = d.local_pc_size-2; i > 1; i--) {
 #else
-        for (int32_t i = d.local_pc_size-3; i >= 0; i--) {
+    for (int32_t i = d.local_pc_size-3; i >= 0; i--) {
 #endif
-            uint64_t index = bisection(d.addresses, d.stack_size, d.local_pc[i]);
-            if(use_colors) {
-                fprintf(stderr, DIM "  File " S_RESET
-                    BOLD MAGENTA "\"%s\"" C_RESET S_RESET
+        uint64_t index = bisection(d.addresses, d.stack_size, d.local_pc[i]);
+        if(use_colors) {
+            fprintf(stderr, DIM "  File " S_RESET
+                BOLD MAGENTA "\"%s\"" C_RESET S_RESET
 #ifdef HAVE_LFORTRAN_MACHO
-                    DIM ", line %lld\n" S_RESET
+                DIM ", line %lld\n" S_RESET
 #else
-                    DIM ", line %ld\n" S_RESET
+                DIM ", line %ld\n" S_RESET
 #endif
-                    "    %s\n", source_filename, d.line_numbers[index],
-                    remove_whitespace(read_line_from_file(source_filename,
-                    d.line_numbers[index])));
-            } else {
-                fprintf(stderr, "  File \"%s\", "
+                "    %s\n", source_filename, d.line_numbers[index],
+                remove_whitespace(read_line_from_file(source_filename,
+                d.line_numbers[index])));
+        } else {
+            fprintf(stderr, "  File \"%s\", "
 #ifdef HAVE_LFORTRAN_MACHO
-                    "line %lld\n    %s\n",
+                "line %lld\n    %s\n",
 #else
-                    "line %ld\n    %s\n",
+                "line %ld\n    %s\n",
 #endif
-                    source_filename, d.line_numbers[index],
-                    remove_whitespace(read_line_from_file(source_filename,
-                    d.line_numbers[index])));
-            }
-#ifdef HAVE_LFORTRAN_MACHO
+                source_filename, d.line_numbers[index],
+                remove_whitespace(read_line_from_file(source_filename,
+                d.line_numbers[index])));
         }
+#ifdef HAVE_LFORTRAN_MACHO
+    }
 #else
-        }
-#endif
     }
+#endif
 }
 
 #endif // HAVE_RUNTIME_STACKTRACE