Skip to content

Conversation

@lucywyman
Copy link
Contributor

@lucywyman lucywyman commented Oct 6, 2025

Pretty straightforward - uses the 'read' function implemented for the resource, similar to other datasources in the repo.

Wait!

  • Have you added comprehensive tests?
  • Have you updated relevant data sources as well as resources?
  • Have you updated the docs?

Testing

For any changes you make, please ensure your acceptance test conform to the following:

  • every single new attribute is tested
  • optional attributes revert to null or default values if removed
  • attributes that interact interact as expected
  • block values behave as expected when reordered
  • nested fields on maps or list/set items function as expected. Terraform does not actually enforce most schema attributes on nested items
  • each test step for a configuration is followed by a test step where ImportState and ImportStateVerify are set to true. ImportStateVerifyIgnore can be used if we explicitly expect a value to be different when imported, such as in the case of obfuscated values like API keys

LaunchDarkly Employees

For more information on how to build, test, and release, see the internal provider runbook.


Related Jira issue: RO-2042: Add release policies datasource in terraform

Pretty straightforward - uses the 'read' function implemented for the
resource, similar to other datasources in the repo.
@lucywyman lucywyman requested review from a team and drewinglis October 6, 2025 21:23
@lucywyman lucywyman requested review from a team as code owners October 6, 2025 21:23
@lucywyman lucywyman changed the title [RO-2042] Add release policy datasource feat: [RO-2042] Add release policy datasource Oct 6, 2025
Copy link

@drewinglis drewinglis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a test for a progressive release policy as well, wdyt?

@lucywyman
Copy link
Contributor Author

I think we should add a test for a progressive release policy as well, wdyt?

Ha! That's funny cursor added a test for that and I removed it cause I didn't think it was necessary :D but yeah I can add one!

@lucywyman lucywyman force-pushed the RO-2042-add-release-policies-datasource-in-terraform branch from 74a5beb to 5a03378 Compare October 7, 2025 20:52
@lucywyman lucywyman force-pushed the RO-2042-add-release-policies-datasource-in-terraform branch from 5a03378 to 8a9a3e7 Compare October 7, 2025 21:29
@lucywyman lucywyman merged commit 5162e5e into preview Oct 7, 2025
26 of 28 checks passed
@lucywyman lucywyman deleted the RO-2042-add-release-policies-datasource-in-terraform branch October 7, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants