feat: OpenFeature Tracking Support #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
approved these changes
Mar 20, 2025
| expect(translateTrackingEventDetails({ value: 12345 })).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('returns object without value attribute', () => { |
There was a problem hiding this comment.
nit: I'd read back through the test names as sentences to make sure they read well that way.
For example "It returns object without value attribute." vs "It returns an object without the value attribute."
|
Looks good! |
abarker-launchdarkly
deleted the
abarker/sdk-1117/openfeature-tracking-support
branch
abarker-launchdarkly
pushed a commit
that referenced
this pull request
Mar 21, 2025
🤖 I have created a release *beep* *boop* --- ## [1.1.0](openfeature-node-server-v1.0.0...openfeature-node-server-v1.1.0) (2025-03-21) ### Features * OpenFeature Tracking Support ([e636f29](e636f29)) * OpenFeature Tracking Support ([#52](#52)) ([0818364](0818364)) * Update minimum node version, and update dev dependencies. ([#50](#50)) ([db4db4c](db4db4c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
https://launchdarkly.atlassian.net/browse/SDK-1117
Describe the solution you've provided
Implemented OpenFeature Provider method
track()in LaunchDarklyProvider. It makes a call under the hood toLDClient.track(). Thevalueattribute will be pulled out of the TrackingEventDetails param and passed toLDClient.track()as metricValue. The remaining object (without value) will be passed toLDClient.track()as data. If the remaining object is empty then undefined will be passed.Describe alternatives you've considered
N/A
Additional context
N/A