feat: fix typedoc and export common types #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #196414: Write in-code docs for typedoc. |
kinyoklion
reviewed
Apr 14, 2023
| LDFlagsStateOptions, | ||
| LDOptions, | ||
| LDOptions as LDOptionsCommon, | ||
| LDContext, |
Member
There was a problem hiding this comment.
There is a secondary problem with the reduced types, because their comments may reference other types that it doesn't know about. Which is possibly we can ignore that.
kinyoklion
reviewed
Apr 14, 2023
Member
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
The docs look much fuller now. 👍
kinyoklion
approved these changes
Apr 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typedoc does not play nice 100% so this is best-effort.