Move appearance ref definition outside useAppearance() #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The appearance ref is currently scoped within the useAppearance composable. Meaning that whenever you import the useAppearance composable a new appearance ref instance will be created. When you need the appearance in multiple places in your app you'll end up with different appearance instances, while its useful if the appearance instance would be the same/stay in sync between all components where it's used.
Moving the appearance definition outside useAppearance resolves this, resulting in the same appearance instance being returned when importing it like: