-
Notifications
You must be signed in to change notification settings - Fork 14.1k
fix: update reset password token when email code verify success #18364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the reset password flow so that a new token is returned and used when email code verification succeeds.
- Updated the response type in verifyResetPasswordCode to include the token.
- Modified the navigation in the success handler to attach the new token to the reset password URL.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
web/service/common.ts | Revised the response type of the verification API to include token |
web/app/reset-password/check-code/page.tsx | Updated token handling in the redirection after verification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the process for refreshing the reset password token upon successful email code verification to ensure the correct token is passed downstream.
- Updated the return type of verifyResetPasswordCode to include the token.
- Modified the router redirection to append the token as a query parameter.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
web/service/common.ts | Updated API response type to include token on code verification. |
web/app/reset-password/check-code/page.tsx | Updated redirection logic to append token to the query string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Tip
Close issue syntax:
Fixes #<issue number>
orResolves #<issue number>
, see documentation for more details.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods