Skip to content

fix: update reset password token when email code verify success #18364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025

Conversation

douxc
Copy link
Collaborator

@douxc douxc commented Apr 18, 2025

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@douxc douxc requested a review from laipz8200 April 18, 2025 08:06
@crazywoola crazywoola requested a review from Copilot April 18, 2025 08:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the reset password flow so that a new token is returned and used when email code verification succeeds.

  • Updated the response type in verifyResetPasswordCode to include the token.
  • Modified the navigation in the success handler to attach the new token to the reset password URL.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
web/service/common.ts Revised the response type of the verification API to include token
web/app/reset-password/check-code/page.tsx Updated token handling in the redirection after verification

@douxc douxc requested a review from Copilot April 18, 2025 08:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the process for refreshing the reset password token upon successful email code verification to ensure the correct token is passed downstream.

  • Updated the return type of verifyResetPasswordCode to include the token.
  • Modified the router redirection to append the token as a query parameter.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
web/service/common.ts Updated API response type to include token on code verification.
web/app/reset-password/check-code/page.tsx Updated redirection logic to append token to the query string.

@douxc douxc marked this pull request as ready for review April 18, 2025 09:02
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Apr 18, 2025
Copy link
Collaborator

@GarfieldDai GarfieldDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 18, 2025
@douxc douxc merged commit 7ba3e59 into main Apr 18, 2025
8 checks passed
@douxc douxc deleted the fix/reset-password-security branch April 18, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants