Skip to content

fix: create child chunk #18209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

devxing
Copy link
Contributor

@devxing devxing commented Apr 16, 2025

Summary

fix create child chunk bug
Resolves #18208

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

…ent_id}/segments/{segment_id}/child_chunks
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Apr 16, 2025
@crazywoola crazywoola requested review from JohnJyong and Copilot and removed request for JohnJyong April 16, 2025 10:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

api/services/dataset_service.py:2028

  • If max_position can be 0 as a valid value, consider explicitly checking for None (e.g., 'if max_position is not None') rather than relying on the falsy evaluation. This helps avoid unintended behavior when 0 is a valid position.
position=max_position + 1 if max_position else 1,

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 16, 2025
@crazywoola crazywoola merged commit e912928 into langgenius:main Apr 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When create child chunk to the segment for the first time, the code has an error
2 participants