-
Notifications
You must be signed in to change notification settings - Fork 14.1k
feat: edit question in Chat #17961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: edit question in Chat #17961
Conversation
Cool~ |
Is it workable with multimodal inputs? |
2025-04-15.15.28.32.movSee attached video @fdb02983rhy, it works with the multi-modal input, however it doesn't support replacing the image for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
web/app/components/workflow/panel/debug-and-preview/chat-wrapper.tsx:98
- [nitpick] Consider renaming the parameter 'chatItem' to 'questionItem' or a similarly descriptive name when an edited question is provided, to improve clarity in distinguishing between the original question and its edited version.
const doRegenerate = useCallback((chatItem: ChatItemInTree, editedQuestion?: { message: string, files?: FileEntity[] }) => {
web/app/components/base/chat/embedded-chatbot/chat-wrapper.tsx:144
- [nitpick] Consider renaming 'chatItem' to a name that clearly indicates it represents the question being regenerated when 'editedQuestion' is provided, which may improve readability.
const doRegenerate = useCallback((chatItem: ChatItemInTree, editedQuestion?: { message: string, files?: FileEntity[] }) => {
web/app/components/base/chat/chat-with-history/chat-wrapper.tsx:145
- [nitpick] Renaming 'chatItem' to a more descriptive name (e.g., 'questionItem') could clarify the context when an edited question is passed.
const doRegenerate = useCallback((chatItem: ChatItemInTree, editedQuestion?: { message: string, files?: FileEntity[] }) => {
web/app/components/app/configuration/debug/debug-with-single-model/index.tsx:129
- [nitpick] Consider renaming 'chatItem' to 'questionItem' or another descriptive name in this context, to better indicate the role of the parameter when handling edited questions.
const doRegenerate = useCallback((chatItem: ChatItemInTree, editedQuestion?: { message: string, files?: FileEntity[] }) => {
Resolves #13110
Demo:
2025-04-1311.mov