fix: published workflow(tool) can be deleted. #17900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a check to prevent deletion of workflows published as tools. Introduces a test suite to ensure proper error handling for workflow deletion, including cases where workflows are drafts, in use by apps, or published as tools. Signed-off-by: -LAN- <[email protected]>
dosubot
bot
added
the
size:L
laipz8200
changed the title
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
api/services/workflow_service.py:519
- [nitpick] Consider introducing a dedicated exception (e.g., WorkflowPublishedToolDeletionError) for workflows published as tools to improve clarity in error handling instead of reusing WorkflowInUseError.
if workflow.tool_published:
api/test_workflow_deletion.py:114
- [nitpick] Consider using an 'in' assertion instead of strict equality for the error message to allow for potential additional context in the exception message.
assert str(excinfo.value) == "Cannot delete workflow that is published as a tool"
Enhances test reliability by using substring assertion for error messages, ensuring that variations in exception details do not cause test failures. Signed-off-by: -LAN- <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
api/services/workflow_service.py:521
- [nitpick] Consider including the workflow identifier or additional context in the error message to help with troubleshooting.
raise WorkflowInUseError("Cannot delete workflow that is published as a tool")
crazywoola
approved these changes
Apr 11, 2025
WTW0313
pushed a commit
that referenced
this pull request
Apr 14, 2025
Signed-off-by: -LAN- <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a check to prevent deletion of workflows published as tools. Introduces a test suite to ensure proper error handling for workflow deletion, including cases where workflows are drafts, in use by apps, or published as tools.
fixes #17193
Tip
Close issue syntax:
Fixes #<issue number>orResolves #<issue number>, see documentation for more details.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods