Skip to content

Update prompts.py:Fix conversation title language for Italian conversations #16696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

zhangkun-21
Copy link
Contributor

Summary

Added 'Italian' to the conversation title prompt to fix an issue where conversations conducted in Italian were incorrectly generating titles in Spanish.

This change ensures that when clients are having conversations in Italian, the generated conversation titles properly match the language of the conversation instead of defaulting to Spanish.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Added 'Italian' in the conversation title prompt, because when my clients were having conversations in Italian, the generated conversation titles were in Spanish.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Mar 25, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 25, 2025
@crazywoola crazywoola merged commit c4bb071 into langgenius:main Mar 25, 2025
6 checks passed
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants