Skip to content

chore: use POSIX shell syntax in pre-commit script #16025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

QuantumGhost
Copy link
Collaborator

Summary

[[ ]] is not supported by POSIX shell, and husky always use sh to run git hook scripts.

Use POSIX shell syntax in the pre-commit script to avoid compatibility and linting problems.

Closes #16021.

Screenshots

N/A

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

`[[ ]]` is not supported by POSIX shell, and husky always use `sh` to
run git hook scripts.

Use POSIX shell syntax in the pre-commit script to avoid compatibility
and linting problems.
@QuantumGhost QuantumGhost requested a review from laipz8200 March 17, 2025 11:26
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 17, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 17, 2025
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazywoola crazywoola merged commit 69fb0a4 into langgenius:main Mar 17, 2025
5 checks passed
@QuantumGhost QuantumGhost deleted the chore/add-ruff-target-version branch March 27, 2025 03:14
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shellcheck in super-linter failed for pre-commit script
3 participants