Skip to content

feat: add debounced enter key submission to install form (#15445) #15542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

jw0903
Copy link
Contributor

@jw0903 jw0903 commented Mar 12, 2025

Summary

This PR includes two improvements:

  1. Added debounce functionality to the Enter key submission on the initial install page, preventing multiple form submissions when users hold down the Enter key. This enhancement improves user experience by avoiding unintended duplicate submissions.

  2. Updated Tailwind CSS class naming to align with v3 conventions, specifically changing placeholder-gray-400 to placeholder:text-gray-400 as per the migration guide.

Tip

Fixes #15445

Key changes:

  • Implemented debounce for Enter key form submission using ahooks's useDebounceFn
  • Set a 200ms debounce wait time to balance responsiveness and protection
  • Utilized React's useCallback for better performance
  • Leveraged existing form submission state from React Hook Form
  • Updated placeholder text color class to follow Tailwind CSS v3 syntax

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Mar 12, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 12, 2025
@crazywoola crazywoola merged commit 0bc4da3 into langgenius:main Mar 12, 2025
5 checks passed
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Mar 12, 2025
* commit '5019547d33eefa870786e5f981907ff2314a639a': (128 commits)
  fix: can not test custom tool (langgenius#15606)
  fix: no attribute error (langgenius#15597)
  fix: trace return null cause page crash (langgenius#15588)
  fix: set marketplace feature to false in feature_service.py (langgenius#15578)
  feat: env MAX_TOOLS_NUM (langgenius#15431)
  chore: use TenantAccountRole instead of TenantAccountJoinRole (langgenius#15514)
  fix: dataset editor (langgenius#15218)
  fix:message api doc (langgenius#15568)
  chore: remove unused parameter (langgenius#15558)
  feat: add debounced enter key submission to install form (langgenius#15445) (langgenius#15542)
  fix: invoke_error is not callable (langgenius#15555)
  fix: workflow loop node break conditions (langgenius#15549)
  fix: remove size prop in PlanBadge component because UpgradeBtn size … (langgenius#15544)
  feat: add click-away and mounting logic to agent setting component (langgenius#15521)
  chore: update opendal version (langgenius#14343)
  fix: nesting of conditional branches causing streaming output error (langgenius#14065)
  fix: update version to 1.0.1 in configuration and Docker files (langgenius#15478)
  fix notion page display (langgenius#15508)
  support workspace billing info (langgenius#15510)
  fix: update placeholders in version info modal to indicate optional field (langgenius#15499)
  ...

# Conflicts:
#	api/poetry.lock
#	web/pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Enable Enter Key Submission for Account Creation on Initial Install Page
2 participants