Fixes 'Nonetype' not iterable for ObsidianLoader (#12751)

Erick Friis · web-flow · commit da821320d36e · 2023-11-01T16:07:09.000-07:00
Implements #12726 from @Di3mex
diff --git a/libs/langchain/langchain/document_loaders/obsidian.py b/libs/langchain/langchain/document_loaders/obsidian.py
@@ -127,7 +127,9 @@ def load(self) -> List[Document]:
             }
 
             if tags or front_matter.get("tags"):
-                metadata["tags"] = ",".join(tags | set(front_matter.get("tags", [])))
+                metadata["tags"] = ",".join(
+                    tags | set(front_matter.get("tags", []) or [])
+                )
 
             docs.append(Document(page_content=text, metadata=metadata))
 

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,9 @@ def load(self) -> List[Document]:`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`if tags or front_matter.get("tags"):`
`130`		`- metadata["tags"] = ",".join(tags \| set(front_matter.get("tags", [])))`
	`130`	`+ metadata["tags"] = ",".join(`
	`131`	`+ tags \| set(front_matter.get("tags", []) or [])`
	`132`	`+ )`
`131`	`133`
`132`	`134`	`docs.append(Document(page_content=text, metadata=metadata))`
`133`	`135`