Refactor compute_deep_composition_poly function #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more than one column
pablodeymo
requested changes
Mar 22, 2023
Comment on lines
67
to
69
| for poly in trace_polys { | ||
| evaluations.push(poly.evaluate_slice(&evaluation_points)); | ||
| } |
There was a problem hiding this comment.
you could have the same programming style than in the precedent assignment
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 95.58% 95.56% -0.03%
==========================================
Files 62 62
Lines 6837 6872 +35
==========================================
+ Hits 6535 6567 +32
- Misses 302 305 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ilitteri
approved these changes
Mar 22, 2023
Oppen
reviewed
Mar 22, 2023
Comment on lines
+190
to
+195
| let poly = (trace_poly.clone() | ||
| - Polynomial::new_monomial(trace_poly.evaluate(eval), 0)) | ||
| / (Polynomial::new_monomial(FieldElement::<F>::one(), 1) | ||
| - Polynomial::new_monomial(eval.clone(), 0)); | ||
|
|
||
| trace_terms = trace_terms + poly * coeff.clone(); |
There was a problem hiding this comment.
Can we avoid some of the clones here?
Comment on lines
+199
to
+207
| let even_composition_poly_term = (even_composition_poly.clone() | ||
| - Polynomial::new_monomial( | ||
| even_composition_poly.evaluate(&ood_evaluation_point.clone()), | ||
| 0, | ||
| )) | ||
| / (Polynomial::new_monomial(FieldElement::one(), 1) | ||
| - Polynomial::new_monomial(ood_evaluation_point * ood_evaluation_point, 0)); | ||
| let fourth_term = (odd_composition_poly.clone() | ||
|
|
||
| let odd_composition_poly_term = (odd_composition_poly.clone() |
jrchatruc
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compute_deep_composition_poly refactor
Description
Closes #183.
This PR refactors the
compute_deep_composition_poly, mainly generalizing for the case the trace has more than one column, or what is the same, that there are more than one trace polynomials.The function has been integrated with Fiat-Shamir too.
Type of change
Please delete options that are not relevant.
Checklist