feat(preflight): build preflight package for AWS #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PengyuanZhao
requested review from
charanbir,
jeffreynglw and
aneesh-mysore
and removed request for
a team
|
Lacework Code Security found potential new issues in this PR. sca found potential 5 new issues
|
jeffreynglw
reviewed
May 28, 2025
Comment on lines
+77
to
+80
| if a == "*" { | ||
| p.caller.IsAdmin = true | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Does this mean we don't need to populate the permissions map below if any of the statement.Action from any document has statement.Action == "*" ?
There was a problem hiding this comment.
Yes. If any action is "*", that will mean the caller can do anything(like having admin access). No need to populate the map to check permissions.
jeffreynglw
reviewed
May 28, 2025
Comment on lines
+22
to
+24
| if strings.Contains(lastStr, "assumed-role") { | ||
| return paths[len(paths)-2], nil | ||
| } |
There was a problem hiding this comment.
I think it would be useful to add an example comment on how this assumed-role Arn might look like.
There was a problem hiding this comment.
Added examples in the comment.
(Audit Mode) sca found potential 5 new issues
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates the package which serves functions to do preflight checks for AWS integrations including Agentless, Config and CloudTrail.
The following tasks will be run sequentially:
How did you test this change?
Run integration test in
preflight_aws_test.go