Skip to content

deps: Update rules_go to v0.22.9 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Conversation

justaugustus
Copy link
Member

Needed for k/k go1.15 update (ref: kubernetes/kubernetes#93264 (comment))

ref: https://github.com/bazelbuild/rules_go/releases/tag/v0.22.9

  • The builder will invoke the Go compiler and linker using response
    files when the length of arguments exceeds operating system limits.
  • go_test will now recompile packages imported by external tests that
    transitively import the library under test. To avoid conflicts with
    the Go 1.15 linker (which has a stricter export data check), it's
    necessary to recompile these packages against the internal test
    archive.

Signed-off-by: Stephen Augustus [email protected]

Thanks @jayconrod!

/assign @fejta
cc: @kubernetes/release-engineering

ref: https://github.com/bazelbuild/rules_go/releases/tag/v0.22.9

- The builder will invoke the Go compiler and linker using response
  files when the length of arguments exceeds operating system limits.
- go_test will now recompile packages imported by external tests that
  transitively import the library under test. To avoid conflicts with
  the Go 1.15 linker (which has a stricter export data check), it's
  necessary to recompile these packages against the internal test
  archive.

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2020
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2020
@justaugustus justaugustus added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jul 23, 2020
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants