k8s-cloud-builder: Build on kube-cross:v1.15.0-rc.2-1 #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Augustus <[email protected]>
'canary' variant image builds are failing because kube-cross canary images are not promoted to production (nor do I think they should be). We can refactor some of this later and reintroduce the k8s-cloud-builder canary image, but for now, let's not unintentionally mask other failures by having the canary variant here. Signed-off-by: Stephen Augustus <[email protected]>
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
area/dependency
k8s-ci-robot
added
size/XS
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area dependency
What this PR does / why we need it:
Updates k8s-cloud-builder to pick up the new
kube-cross:v1.15.0-rc.2-1images (ref: kube-cross: Build v1.15.0-rc.2-1 image #1482, build-image: Promote kube-cross:v1.15.0-rc.2-1 k8s.io#1129)Drop 'canary' variant
'canary' variant image builds are failing because kube-cross canary
images are not promoted to production (nor do I think they should be).
We can refactor some of this later and reintroduce the k8s-cloud-builder
canary image, but for now, let's not unintentionally mask other
failures by having the canary variant here.
example: https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/post-release-push-image-k8s-cloud-builder/1292272548595109889
Part of go1.15 updates: #1421
/assign @tpepper @saschagrunert @cpanato @hasheddan
cc: @kubernetes/release-engineering
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?