Skip to content

kube-cross: Build v1.14.7-1 and v1.13.15-1 images #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2020
Merged

kube-cross: Build v1.14.7-1 and v1.13.15-1 images #1473

merged 1 commit into from
Aug 7, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Aug 7, 2020 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency security
/priority important-soon

What this PR does / why we need it:

Build v1.14.7-1 and v1.13.15-1 images

Tracking issue: #1474
ref: https://groups.google.com/d/topic/golang-announce/NyPIaucMgXo/discussion, https://kubernetes.slack.com/archives/C2C40FMNF/p1596737718036900

Signed-off-by: Stephen Augustus [email protected]

/assign @tpepper @saschagrunert @hasheddan @cpanato
cc: @kubernetes/release-engineering @dims @liggitt

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-cross: Build v1.14.7-1 and v1.13.15-1 images

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 7, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: The label(s) area/security cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind feature
/area dependency security
/priority important-soon

What this PR does / why we need it:

Build v1.14.7-1 and v1.13.15-1 images

ref: https://groups.google.com/d/topic/golang-announce/NyPIaucMgXo/discussion, https://kubernetes.slack.com/archives/C2C40FMNF/p1596737718036900

Signed-off-by: Stephen Augustus [email protected]

/assign @tpepper @saschagrunert @hasheddan @cpanato
cc: @kubernetes/release-engineering @dims @liggitt

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/hold for the image to actually be available

Does this PR introduce a user-facing change?

kube-cross: Build v1.14.7-1 and v1.13.15-1 images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2020
@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 95cbb9f into kubernetes:master Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 7, 2020
This was referenced Aug 7, 2020
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@dims dims Awaiting requested review from dims

Assignees

@saschagrunert saschagrunert

@BenTheElder BenTheElder

@tpepper tpepper

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
7 participants
@justaugustus @k8s-ci-robot @BenTheElder @saschagrunert @tpepper @cpanato @hasheddan