Skip to content

kube-cross: Build v1.15.0-rc.1-1 image #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind feature
/area dependency
/priority important-soon

What this PR does / why we need it:

Build kube-cross v1.15.0-rc.1-1 image

Tracking issue: #1421.
ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1595620045212200?thread_ts=1595270953.060000&cid=C2C40FMNF

Signed-off-by: Stephen Augustus [email protected]

/assign @tpepper @saschagrunert @hasheddan @cpanato @dims @liggitt
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/hold for the image to actually be available

Does this PR introduce a user-facing change?

kube-cross: Build v1.15.0-rc.1-1 image

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 24, 2020
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@justaugustus justaugustus mentioned this pull request Jul 24, 2020
33 tasks
@BenTheElder
Copy link
Member

if we're still using the dockerhub golang image rc1 doesn't appear to exist yet

@justaugustus
Copy link
Member Author

if we're still using the dockerhub golang image rc1 doesn't appear to exist yet

/hold for the image to actually be available

Yep. 😅
I might be looking into getting our own golang images rolling after we land go1.15.0.

@BenTheElder
Copy link
Member

@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

/hold
except like, only a couple architectures (??)

@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 998d033 into kubernetes:master Jul 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants